Set resource limit for kube-ui addon container. #10778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
zmerlynn
added
the
lgtm
|
LGTM I sure hope we have 50M to spare. |
|
GCE e2e build/test failed for commit 747f84d. |
|
ok to test |
|
GCE e2e build/test passed for commit 747f84d. |
yujuhong
added a commit
that referenced
this pull request
Jul 6, 2015
Set resource limit for kube-ui addon container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I left from #10653 for newly introduced addon container: kube-ui. Measurement is based on current default configuration for GCE / GKE (?) and AWS: 4 nodes, 30~50 pods per node.
Based on measurement, kube-ui uses tiny bit of resources on both cpu and memory. I decided to allocate 100m for cpu even they all use less than that since it matches today's default setting from LimitRange of default namespace anyway. For memory it uses ~10M after many poke and explore on ui. I allocated 50M to it.
cc/ @zmerlynn @lavalamp @bgrant0607